-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into logs #2107
Merge main into logs #2107
Conversation
According to the spec: > The attribute key, which MUST be a non-null and non-empty string. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md
* Added support for `OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT` Fixes open-telemetry#2045 Fixes open-telemetry#2043 Fixes open-telemetry#2042 Fixes open-telemetry#2041 * SpanLimit: Treat empty value env vars as unset Fixes open-telemetry#2052 * Update CHANGELOG.md Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Leighton Chen <lechen@microsoft.com>
…emetry#2056) * Added support for `OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT` Fixes open-telemetry#2045 Fixes open-telemetry#2043 Fixes open-telemetry#2042 Fixes open-telemetry#2041
* Update to semantic conventions v1.6.1 * Add CHANGELOG entry * Fix lint
* Rename base test assertion methods for consistency * Renamed assertion method * Updated contrib SHA * Updated contrib SHA
* Escape reserved characters in baggage keys Fixes open-telemetry#2072 * Add extract tests * Fix lint
* Updated website docs * Update docs/getting-started.rst Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Leighton Chen <lechen@microsoft.com>
Run tests on Windows in Github CI
* Add pre and post instrument entry points Fixes open-telemetry#1982 Co-authored-by: Owais Lone <owais@users.noreply.github.com>
Do not count invalid attributes for dropped Co-authored-by: Owais Lone <owais@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@lzchen I am curious, how do you plan to merge this? "Squash and Merge" or "Create a merge commit"? Since all this code has been reviewed, another option is for a maintainer to just occasionally run |
@aabmass |
No description provided.